-
Notifications
You must be signed in to change notification settings - Fork 25
[full-ci] flush all the build cache #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7911b2b to
7f8eb4e
Compare
1815979 to
c210276
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new pipelines to purge various caches—specifically for Opencloud build, browsers, and playwright tracing—to improve the cleanup process after builds.
- Updated the afterPipelines function to include purge functions for Opencloud build, browser, and tracing caches.
- Refactored cache purging by replacing genericCachePurge with a more generic purgeCache function that accepts an additional flush_age parameter.
- Introduced dedicated purge functions for Opencloud build, browser, and tracing caches.
Comments suppressed due to low confidence (3)
.woodpecker.star:247
- Consider adding inline comments that explain the order and purpose of each cache purge function added here to help future maintainers understand the cache clearing sequence.
return publishRelease(ctx) + [purgeBuildArtifactCache(ctx), purgeOpencloudBuildCache(ctx), purgeBrowserCache(ctx), purgeTracingCache(ctx)]
.woodpecker.star:1187
- Verify that the pipeline executor accepts a dictionary for the 'steps' field instead of a list, as used in previous implementations. If this change is intentional, consider adding a brief comment outlining the rationale for future reference.
"steps": {
.woodpecker.star:1209
- Double-check that the hardcoded flush path 'cache/opencloud-eu/web' is intentional and aligns with the desired cache location for build artifacts, especially in comparison to other purge functions.
return purgeCache("purge_build_artifact_cache", "cache/opencloud-eu/web", 1)
individual-it
requested changes
Jun 25, 2025
c210276 to
ca5ed81
Compare
ca5ed81 to
26ebcc5
Compare
individual-it
approved these changes
Jun 25, 2025
Signed-off-by: prashant-gurung899 <prasantgrg777@gmail.com>
26ebcc5 to
8586c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following pipelines to purge the cache of
browsers,playwright-tracing-resultsandopencloud-build:purge-browser-build-cachepurge-playwright-tracing-cachepurge-opencloud-build-cacheCheck these previous CIs to see the cache being deleted:
Related Issue
How Has This Been Tested?
Types of changes