delete logo steps #834
Merged
delete logo steps #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes the now-orphaned logo upload/reset test utilities and step definitions after the corresponding feature was deleted.
- Deleted the
Generalpage object (index.ts) underapp-admin-settings/general - Removed the associated actions file (
actions.ts) - Eliminated the Cucumber step definitions for uploading and resetting the logo
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-admin-settings/general/index.ts | Removed the General class and its upload/resetLogo methods |
| tests/e2e/support/objects/app-admin-settings/general/actions.ts | Deleted uploadLogo and resetLogo action implementations |
| tests/e2e/cucumber/steps/ui/adminSettings.ts | Stripped out the two logo-related Then step definitions |
Comments suppressed due to low confidence (1)
tests/e2e/support/objects/app-admin-settings/general/index.ts:1
- After deleting all files in this directory, consider removing the now-empty
generalfolder to avoid orphaned directories in the repo.
-import { Page } from '@playwright/test'
ScharfViktor
force-pushed
the
deleteLogoSteps
branch
from
112b51d to
73ea691
Compare
AlexAndBear
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the #432 we deleted feature file for uploading the logo
in this PR I deleted step definition