Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the status indicators shown in the tiles view by hiding specific space-related indicators.

  • Replaces the inline filter to exclude space-enabled/disabled indicators.
  • Introduces showStatusIndicator helper to centralize filter logic.
  • Tidies up import ordering for composables and helpers.
Comments suppressed due to low confidence (2)

packages/web-pkg/src/components/FilesList/ResourceTiles.vue:95

  • Add unit tests for showStatusIndicator to verify that it correctly filters out the space-enabled and space-disabled indicators in different scenarios.
:filter="(indicator) => showStatusIndicator(indicator)"

packages/web-pkg/src/components/FilesList/ResourceTiles.vue:584

  • [nitpick] Add a JSDoc or inline comment explaining the purpose of showStatusIndicator and the filtering criteria for clarity.
const showStatusIndicator = (indicator: ResourceIndicator) => {

@AlexAndBear
Copy link
Contributor Author

@JammingBen we could also just change the category of the space indicators and don't change other code paths, but system is kind of a legit category IDK 🥹

@AlexAndBear AlexAndBear force-pushed the fix-tiles-view-show-space-status-indicators branch from 36d5200 to 3ad38aa Compare June 13, 2025 11:55
@AlexAndBear AlexAndBear merged commit 74b920e into main Jun 13, 2025
18 checks passed
@AlexAndBear AlexAndBear deleted the fix-tiles-view-show-space-status-indicators branch June 13, 2025 12:07
@openclouders openclouders mentioned this pull request Jun 13, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants