Skip to content

Conversation

@AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI review requested due to automatic review settings June 2, 2025 14:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses the issue of avatar initials not showing in the shares table by switching the bound property from userName to displayName.

  • Updated bindings to use avatar.displayName instead of avatar.userName in two locations.
Comments suppressed due to low confidence (2)

packages/web-pkg/src/components/FilesList/ResourceTable.vue:211

  • Ensure that all avatar objects reliably include the displayName property or provide an appropriate fallback if not, to avoid potential display issues.
              :user-name="avatar.displayName"

packages/web-pkg/src/components/FilesList/ResourceTable.vue:238

  • Ensure that the update to use displayName is consistently supported by the data model across all usages, considering the possibility of missing values.
              :user-name="avatar.displayName"

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. works fine.
thank you for fix 👍

@AlexAndBear AlexAndBear merged commit 3df706a into main Jun 2, 2025
19 of 20 checks passed
@AlexAndBear AlexAndBear deleted the avatar-followup branch June 2, 2025 14:34
@openclouders openclouders mentioned this pull request Jun 2, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants