e2e tests. user profile photo #742
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds e2e test support for user profile photo functionality by incorporating new methods and test steps for uploading, changing, and deleting profile photos.
- New methods in the account object for handling profile image actions
- Updated actions to handle file uploads, deletion, and picture retrieval
- Added cucumber steps and feature tests to validate profile photo operations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/support/objects/account/index.ts | Added methods for uploading, deleting, and retrieving profile images |
| tests/e2e/support/objects/account/actions.ts | Implemented actions to support profile image operations |
| tests/e2e/cucumber/steps/ui/accountMenu.ts | Updated cucumber steps for profile image interactions |
| tests/e2e/cucumber/features/user-settings/profilePhoto.feature | New feature file to validate profile image use cases |
Comments suppressed due to low confidence (2)
tests/e2e/support/objects/account/index.ts:44
- The method deleteProfileImage calls deleteProfilePicture, resulting in inconsistent naming. Consider standardizing naming (e.g., using 'ProfileImage' or 'ProfilePicture' consistently) across the related methods.
await po.deleteProfilePicture({ page: this.#page })
tests/e2e/cucumber/features/user-settings/profilePhoto.feature:12
- There is inconsistent terminology between the feature file ('profile photo', 'profile image') and the code (methods referring to 'ProfileImage' and 'ProfilePicture'). Consider unifying the terminology across tests and implementation.
When "Alice" uploads the profile image "testavatar.jpeg"
|
tests will work after we get a backend with opencloud-eu/opencloud#864 |
AlexAndBear
left a comment
AlexAndBear
left a comment
There was a problem hiding this comment.
LGTM 👍, let's wait for backend to be merged ⏰
|
this is something new: e2e-tests-2 is green but it shows up here as Since it's not related to my PR -> I merge it without restarting CI |
|
@ScharfViktor I also got some woodpecker pipelines, that were green but not reporting back to gh and were pending |
related: #582
test for: