feat: polish account page followup #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
requested review from
Copilot and
kulmann
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR polishes the account page's app token deletion UI by adding an ARIA label for accessibility and shortening the visible delete button text.
- Adds
aria-labelto the delete button - Updates visible button text from “Delete app token” to “Delete”
| gap-size="none" | ||
| size="small" | ||
| class="delete-app-token-btn" | ||
| :aria-label="$gettext('Delete app token')" |
There was a problem hiding this comment.
Consider including the specific token name in the aria-label (e.g., "Delete app token ‹tokenName›") to provide more context for screen reader users when multiple tokens are listed.
Suggested change
| :aria-label="$gettext('Delete app token')" | |
| :aria-label="`${$gettext('Delete app token')} ${item.label || '-'}`" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes