Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

request https://host.docker.internal:9200//graph/v1beta1/extensions/org.libregraph/activities?kql=itemid=itemUUID gets value: [] that leads to test failures:

Expected string: "Alice Hansen deleted subFolder from sharedFolder"
Received string: "No activities"

There are two ways to do this:

  • request actions over and over again (the dramaturg test goes fast)
  • set ACTIVITYLOG_WRITE_BUFFER_DURATION=0 (selected way)

Copilot AI review requested due to automatic review settings May 21, 2025 07:35
@ScharfViktor ScharfViktor requested review from aduffeck and kulmann and removed request for Copilot May 21, 2025 07:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the write buffer for activity tests by setting ACTIVITYLOG_WRITE_BUFFER_DURATION to 0 in various configuration files and synchronizing the UI activity panel load with a GET request.

  • Updates the activity panel opening logic in the end-to-end tests to wait for an activity GET response.
  • Sets ACTIVITYLOG_WRITE_BUFFER_DURATION to '0' in docker-compose files and deployment scripts.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/e2e/support/objects/app-files/resource/actions.ts Adjusted panel opening to concurrently await the GET response and panel open call.
docker-compose.yml Added ACTIVITYLOG_WRITE_BUFFER_DURATION environment variable.
deployments/examples/oc_web/docker-compose.yml Added ACTIVITYLOG_WRITE_BUFFER_DURATION to ensure consistency.
.woodpecker.star Updated environment configuration to disable the write buffer.

@ScharfViktor ScharfViktor force-pushed the disableWriteBufferForActivityTests branch from 541fd6f to 31e8227 Compare May 21, 2025 07:59
@ScharfViktor ScharfViktor requested a review from JammingBen May 21, 2025 08:41
@ScharfViktor ScharfViktor merged commit a875e77 into main May 21, 2025
18 checks passed
@ScharfViktor ScharfViktor deleted the disableWriteBufferForActivityTests branch May 21, 2025 14:01
@openclouders openclouders mentioned this pull request May 21, 2025
1 task
@openclouders openclouders mentioned this pull request Jun 2, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants