feat: Added CalDAV URL to the Accountpage #693

tammi-23 · 2025-05-14T12:51:45Z

Added a Calendar Panel to the User Account Page.
This includes: CalDAV URL, username and an information about the Calendar-Implementaion.

This implements: #600

packages/web-runtime/src/components/Account/CalDavUrl.vue

tbsbdr · 2025-05-15T08:18:31Z

forwarding screenies from @tammi-23 - @db-ot could oyu please provide feedback?

packages/web-runtime/src/components/Account/CalDavUrl.vue

tammi-23 · 2025-05-15T19:17:23Z

With the latest push, I updated the Radicale/CalDAV check to verify whether the redirect URL includes /caldav/.
→ #600

I also extended OcTag.vue by adding a color prop with a default value and implemented our website's highlight color (#ca8df5) as a custom option.

Additionally, I added a new configuration to our Docker development stack to enable Radicale.

Still missing: Unit Tests

JammingBen

A few annotations from my side, but overall it looks quite good already!

docker-compose.yml

packages/design-system/src/components/OcTag/OcTag.vue

packages/web-runtime/src/components/Account/CalDavUrl.vue

packages/web-runtime/tests/unit/components/Account/CalDavUrl.spec.ts

AlexAndBear · 2025-05-21T14:31:48Z

packages/web-runtime/src/components/Account/CalDavUrl.vue

+const calDavAvailable = ref(false)
+const copiedIcon = 'check'
+const copyIcon = 'file-copy'
+const checked = ref(false)


Maybe we can give the variable a more descriptive naming

AlexAndBear · 2025-05-21T14:33:26Z

packages/web-runtime/src/components/Account/CalDavUrl.vue

+        calDavAvailable.value = true
+      }
+    } catch (error) {
+      console.error('CalDAV check failed:', error)


Suggested change

console.error('CalDAV check failed:', error)

console.info('CalDAV check failed:', error)

Since CalDav is not required for a working OpenCloud Instance, I wouldn't announce an error

JammingBen

Some final cleanup, rest LGTM 👍

JammingBen · 2025-05-21T14:30:51Z

docker-compose.yml

+      #traefik.http.routers.opencloud.middlewares: cors,redirect-caldav
+      #traefik.http.middlewares.redirect-caldav.redirectregex.regex: '^/.well-known/caldav$'
+      #traefik.http.middlewares.redirect-caldav.redirectregex.replacement: '/caldav/'
+      #traefik.http.middlewares.redirect-caldav.redirectregex.permanent: true
+


Suggested change

#traefik.http.routers.opencloud.middlewares: cors,redirect-caldav

#traefik.http.middlewares.redirect-caldav.redirectregex.regex: '^/.well-known/caldav$'

#traefik.http.middlewares.redirect-caldav.redirectregex.replacement: '/caldav/'

#traefik.http.middlewares.redirect-caldav.redirectregex.permanent: true

JammingBen · 2025-05-21T14:31:30Z

docker-compose.yml

+      traefik.http.middlewares.radicale-redirect.redirectregex.regex: '^http://(.*):5232(.*)'
+      traefik.http.middlewares.radicale-redirect.redirectregex.replacement: 'http://$1:9201$2'
+      traefik.http.middlewares.radicale-redirect.redirectregex.permanent: true


I think these can be removed as well?

Suggested change

traefik.http.middlewares.radicale-redirect.redirectregex.regex: '^http://(.*):5232(.*)'

traefik.http.middlewares.radicale-redirect.redirectregex.replacement: 'http://$1:9201$2'

traefik.http.middlewares.radicale-redirect.redirectregex.permanent: true

JammingBen · 2025-05-21T14:31:47Z

docker-compose.yml

+    #labels:
+    #traefik.enable: true
+    #traefik.http.routers.radicale.tls: true
+    #traefik.http.routers.radicale.rule: PathPrefix(`/`)
+    #traefik.http.routers.radicale.entrypoints: websecure
+    #traefik.http.services.radicale.loadbalancer.server.port: 5232


Suggested change

#labels:

#traefik.enable: true

#traefik.http.routers.radicale.tls: true

#traefik.http.routers.radicale.rule: PathPrefix(`/`)

#traefik.http.routers.radicale.entrypoints: websecure

#traefik.http.services.radicale.loadbalancer.server.port: 5232

AlexAndBear

🎉

…config to include radicale in web-dev stack.

AlexAndBear · 2025-05-21T20:11:25Z

packages/web-runtime/src/components/Account/CalDavUrl.vue

+      <oc-table-tr class="account-page-info-caldav-url">
+        <oc-table-td>{{ $gettext('CalDAV URL') }}</oc-table-td>
+        <oc-table-td>
+          <span class="oc-text-truncate">{{ configStore.serverUrl }}</span>


Did this change ? I thought we need a full url with /caldav slug, now its only the server url ?

Only the server URL is correct, because calendar apps will use the .well-known endpoints automagically.

* feat: Added Calendar for CalDAV URL to the Accountpage (only for radicale) * feat: Include radicale in web-dev stack. --------- Co-authored-by: Jannik Stehle <j.stehle@opencloud.eu> Co-authored-by: Alex Ackermann <abackermann91@gmail.com>

tammi-23 added the Type:Feature-Request label May 14, 2025

tammi-23 requested review from AlexAndBear, JammingBen and kulmann May 14, 2025 12:52

AlexAndBear requested changes May 14, 2025

View reviewed changes

AlexAndBear requested changes May 15, 2025

View reviewed changes

packages/web-runtime/src/components/Account/CalDavUrl.vue Outdated Show resolved Hide resolved

packages/web-runtime/src/components/Account/CalDavUrl.vue Outdated Show resolved Hide resolved

JammingBen reviewed May 16, 2025

View reviewed changes

AlexAndBear requested changes May 21, 2025

View reviewed changes

JammingBen reviewed May 21, 2025

View reviewed changes

AlexAndBear approved these changes May 21, 2025

View reviewed changes

tammi-23 and others added 10 commits May 21, 2025 21:44

feat: Added CalDAV URL to the Accountpage

f5bc2ed

feat: Updated CalDavCheck, color added to OC tag props and added new …

5b9023e

…config to include radicale in web-dev stack.

fix: adjusted code for lint check

97546d9

Added Unit test

06b97ae

wip: to view chnages in test

8d81024

fix: unit tests

9edd7bc

fix: formating and linting

5a6e316

fix: linting

c9fc24e

fix: adjusted OcTag Spec Snapshot for unit test

df09a2d

chore: renaming variable and deleting comments

d035ae9

AlexAndBear force-pushed the feat/600 branch from a55e91e to 6a89c14 Compare May 21, 2025 20:09

AlexAndBear reviewed May 21, 2025

View reviewed changes

adjust to account page redesign

a1ae497

AlexAndBear force-pushed the feat/600 branch from 6a89c14 to a1ae497 Compare May 21, 2025 20:21

tammi-23 added 2 commits May 22, 2025 10:59

removed double check

545a89f

adjusted unit test to latest changes

5f74703

tammi-23 merged commit 18c7281 into main May 22, 2025
18 checks passed

tammi-23 deleted the feat/600 branch May 22, 2025 09:36

openclouders mentioned this pull request May 22, 2025

🎉 Release 3.0.0-alpha.1 #718

Merged

1 task

openclouders mentioned this pull request Jun 2, 2025

🎉 Release 3.0.0 #785

Merged

1 task

	console.error('CalDAV check failed:', error)
	console.info('CalDAV check failed:', error)

	traefik.http.middlewares.radicale-redirect.redirectregex.regex: '^http://(.):5232(.)'
	traefik.http.middlewares.radicale-redirect.redirectregex.replacement: 'http://$1:9201$2'
	traefik.http.middlewares.radicale-redirect.redirectregex.permanent: true

feat: Added CalDAV URL to the Accountpage #693

feat: Added CalDAV URL to the Accountpage #693

Uh oh!

Conversation

tammi-23 commented May 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tbsbdr commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tammi-23 commented May 15, 2025

Uh oh!

JammingBen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexAndBear May 21, 2025

Choose a reason for hiding this comment

Uh oh!

AlexAndBear May 21, 2025

Choose a reason for hiding this comment

Uh oh!

JammingBen left a comment

Choose a reason for hiding this comment

Uh oh!

JammingBen May 21, 2025

Choose a reason for hiding this comment

Uh oh!

JammingBen May 21, 2025

Choose a reason for hiding this comment

Uh oh!

JammingBen May 21, 2025

Choose a reason for hiding this comment

Uh oh!

AlexAndBear left a comment

Choose a reason for hiding this comment

Uh oh!

AlexAndBear May 21, 2025

Choose a reason for hiding this comment

Uh oh!

kulmann May 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tbsbdr commented May 15, 2025 •

edited

Loading