Skip to content

feat: add profile pictures #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexAndBear merged 2 commits into from
May 23, 2025
Merged

feat: add profile pictures #626

AlexAndBear merged 2 commits into from
May 23, 2025

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 3, 2025 •
edited
Loading

Description

image

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented May 3, 2025 •
edited
Loading

@kulmann @tbsbdr I am waiting for the backend part to be finished.
Could you check if you agree with the look & feel of the avatar upload ?

I added a crop mechanism, even if this was not part of the story.

@tbsbdr could you check the texts additionally ?

AlexAndBear
AlexAndBear commented May 3, 2025
View reviewed changes
AlexAndBear
AlexAndBear commented May 3, 2025
View reviewed changes
@AlexAndBear AlexAndBear force-pushed the issues/582 branch 3 times, most recently from 09c3c67 to a1bed78 Compare May 3, 2025 21:34
AlexAndBear
AlexAndBear commented May 4, 2025
View reviewed changes
AlexAndBear
AlexAndBear commented May 5, 2025
View reviewed changes
AlexAndBear
AlexAndBear commented May 5, 2025
View reviewed changes
@AlexAndBear AlexAndBear requested a review from JammingBen May 12, 2025 12:24
@AlexAndBear AlexAndBear force-pushed the issues/582 branch 2 times, most recently from bef92b1 to e7edd0b Compare May 21, 2025 11:34
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented May 21, 2025

waiting for opencloud-eu/opencloud#864

@AlexAndBear AlexAndBear force-pushed the issues/582 branch 2 times, most recently from 2d90730 to a98357b Compare May 21, 2025 17:34
@AlexAndBear AlexAndBear requested a review from kulmann May 21, 2025 17:36
@AlexAndBear AlexAndBear marked this pull request as ready for review May 21, 2025 17:37
kulmann
kulmann requested changes May 22, 2025
View reviewed changes
@AlexAndBear AlexAndBear force-pushed the issues/582 branch 2 times, most recently from ed7e462 to df72062 Compare May 22, 2025 17:52
@AlexAndBear AlexAndBear requested a review from kulmann May 22, 2025 17:53
JammingBen
JammingBen reviewed May 23, 2025
View reviewed changes
@AlexAndBear AlexAndBear requested a review from JammingBen May 23, 2025 09:25
kulmann
kulmann reviewed May 23, 2025
View reviewed changes
@AlexAndBear AlexAndBear requested a review from kulmann May 23, 2025 10:00
kulmann
kulmann approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah dude! This is awesome 🧑‍🎨

@AlexAndBear AlexAndBear merged commit 946f1c4 into main May 23, 2025
18 checks passed
@AlexAndBear AlexAndBear deleted the issues/582 branch May 23, 2025 11:21
@openclouders openclouders mentioned this pull request May 23, 2025
Merged
1 task
@openclouders openclouders mentioned this pull request Jun 2, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@AlexAndBear AlexAndBear

@JammingBen JammingBen

Labels

Status:Blocked Type:Feature-Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Personal touch: Add profile pictures

4 participants

@AlexAndBear @kulmann @JammingBen