Skip to content

Conversation

@kulmann
Copy link
Contributor

@kulmann kulmann commented Mar 20, 2025

Description

Since the app token passwords will be longer from now on, the modal was looking weird. Restyled it a little bit.

Screenshot 2025-03-20 at 11 22 34

Types of changes

  • Bugfix
  • New feature (an additional functionality that doesn't break existing code)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the visual layout of the app token modal to accommodate longer token values by restyling and reorganizing elements within the modal.

  • Updated the token display container to include new spacing and background styling.
  • Adjusted the positioning of the expiration date text for improved visual alignment.
Comments suppressed due to low confidence (2)

packages/web-runtime/src/components/Modals/AppTokenModal.vue:36

  • [nitpick] Removing the previous padding class (oc-pr-m) on the created-token-container might affect the layout spacing; please confirm that the new spacing meets the design requirements.
<div class="created-token-container">

packages/web-runtime/src/components/Modals/AppTokenModal.vue:113

  • [nitpick] Replacing the border-right styling with a full-width container should be reviewed to ensure it does not compromise the visual separation between elements in different viewport sizes.
width: 100%;

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit 0661506 into main Mar 20, 2025
@kulmann kulmann deleted the app-token-modal-styling branch March 20, 2025 10:47
This was referenced Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants