fix(pkg): pixelated previews after searching #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where loaded previews in the file list would be pixelated after using the search preview.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the pixelated preview issue after search and refactors the ResourcePreview component to use script setup.
- Updated type casting and snapshot testing in the unit tests
- Refactored ResourcePreview.vue to use script setup with updated lifecycle hooks and prop destructuring
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web-pkg/tests/unit/components/Search/ResourcePreview.spec.ts | Adjusted type casting for testing and updated component stub reference |
| packages/web-pkg/src/components/Search/ResourcePreview.vue | Converted component to script setup, updated lifecycle hooks, and modified prop usage |
kulmann
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where loaded previews in the file list would be pixelated after using the search preview and refactors the component to script setup on the way.
fixes #370