-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add photo roll to preview app #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a photo roll navigation panel to the preview app, allowing users to see thumbnails of all previewable files and navigate between them.
Key Changes:
- Modified the
CachedFiletype to makeurlan optional Vue ref for reactive preview URL updates - Created a new
PhotoRoll.vuecomponent that displays a vertical thumbnail list with auto-scrolling to active items - Updated the
App.vueto integrate the photo roll, simplify preloading logic, and handle photo roll selection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web-app-preview/src/helpers/types.ts | Changed url property from string to optional Vue ref for reactive preview URLs |
| packages/web-app-preview/src/components/PhotoRoll.vue | Added new photo roll component with thumbnail display and navigation |
| packages/web-app-preview/src/App.vue | Integrated photo roll component, updated URL handling to use refs, and simplified preloading logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Great idea 🥇
feat: add photo roll to preview app
|
Please make it optional via env-var as it produces heavy load on Server-CPUs. Opencloud runs for months with loads up to 1.5 until now. But the use of the Photo-roll by a single user crashes the system and makes opencloud unusable for me on that computer. |

Description
Related Issue
How Has This Been Tested?
Types of changes