feat: add floating action button #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new floating action button component to create emails, improving mobile UX by replacing the static "Write new Email" button with a floating action button that only appears on mobile devices.
Key changes:
- Created a reusable
OcFloatingActionButtoncomponent with action and menu modes - Moved the "Write new Email" button from
MailList.vuetoMailboxTree.vuefor desktop view - Added the floating action button to
MailList.vuefor mobile view
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-app-mail/src/components/MailboxTree.vue |
Added "Write new Email" button for desktop view (hidden on mobile) |
packages/web-app-mail/src/components/MailList.vue |
Replaced static button with floating action button for mobile, removed old button implementation |
packages/design-system/src/components/index.ts |
Exported the new OcFloatingActionButton component |
packages/design-system/src/components/OcFloatingActionButton/OcFloatingActionButton.vue |
Implemented new floating action button component with action and menu modes |
packages/design-system/docs/components/OcFloatingActionButton/OcFloatingActionButton.md |
Added documentation with usage examples |
packages/design-system/docs/.vitepress/config.ts |
Added navigation entry for the new component documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| class="md:hidden" | ||
| mode="action" | ||
| :aria-label="$gettext('Write new Email')" | ||
| :items="[{ to: { name: 'mail-create', query: { ...route.query, draftId: 'new' } } }]" |
There was a problem hiding this comment.
The floating action button items array is missing an icon property. In action mode, users may still benefit from seeing an icon. Consider adding icon: 'edit-box' to match the desktop button implementation.
Suggested change
| :items="[{ to: { name: 'mail-create', query: { ...route.query, draftId: 'new' } } }]" | |
| :items="[{ to: { name: 'mail-create', query: { ...route.query, draftId: 'new' } }, icon: 'edit-box' }]" |
packages/design-system/src/components/OcFloatingActionButton/OcFloatingActionButton.vue
Show resolved
Hide resolved
packages/design-system/src/components/OcFloatingActionButton/OcFloatingActionButton.vue
Show resolved
Hide resolved
JammingBen
reviewed
Dec 1, 2025
packages/design-system/src/components/OcFloatingActionButton/OcFloatingActionButton.vue
Show resolved
Hide resolved
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
openclouders
pushed a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes