Skip to content

Mail: Mail compose as Widget #1609 #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tammi-23 merged 12 commits into from
Dec 18, 2025
Merged

Mail: Mail compose as Widget #1609 #1687

tammi-23 merged 12 commits into from
Dec 18, 2025
+333 −178

Conversation

@tammi-23
Copy link
Contributor

@tammi-23 tammi-23 commented Dec 1, 2025

PR for #1609

@tammi-23 tammi-23 marked this pull request as ready for review December 4, 2025 13:24
Copilot AI review requested due to automatic review settings December 4, 2025 13:25
Copilot AI reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements mail composition as a widget, allowing users to compose emails in a floating widget interface instead of navigating to a separate route. The widget can be expanded to a modal view and provides a more streamlined user experience.

Key Changes:

  • Replaced router-link navigation with event-driven widget opening for composing emails
  • Added a new MailWidget component with collapsible/expandable functionality
  • Created MailComposeForm component to handle email composition logic

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/web-app-mail/src/views/Inbox.vue Added event handler to trigger compose widget from mailbox tree
packages/web-app-mail/src/components/MailboxTree.vue Replaced router-link with event emission for compose action
packages/web-app-mail/src/components/MailWidget.vue New widget component with expandable/collapsible compose interface
packages/web-app-mail/src/components/MailList.vue Integrated widget and exposed openCompose method via ref
packages/web-app-mail/src/components/MailComposeForm.vue New form component handling email composition state and validation
packages/design-system/src/components/OcModal/OcModal.vue Added header actions slot for custom modal header buttons
packages/design-system/src/components/OcModal/__snapshots__/OcModal.spec.ts.snap Updated snapshots to reflect new header actions slot

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tammi-23 tammi-23 requested a review from AlexAndBear December 4, 2025 13:31
kulmann
kulmann reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to kill the import for MailCompose.vue and the corresponding route in index.ts.

AlexAndBear
AlexAndBear requested changes Dec 5, 2025
View reviewed changes
JammingBen
JammingBen reviewed Dec 8, 2025
View reviewed changes
Copilot AI reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JammingBen
JammingBen reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nitpick, rest LGTM!

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Dec 16, 2025 •
edited
Loading

On a small viewport the mail compose is not acccessible, it should be at least scrollable

image

@tammi-23 tammi-23 requested a review from JammingBen December 18, 2025 14:45
JammingBen
JammingBen approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tammi-23 tammi-23 enabled auto-merge December 18, 2025 15:23
AlexAndBear
AlexAndBear approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top notch ⭐

@tammi-23 tammi-23 merged commit 682a6c6 into main Dec 18, 2025
28 checks passed
@tammi-23 tammi-23 deleted the feat/1609 branch December 18, 2025 16:16
@openclouders openclouders mentioned this pull request Dec 18, 2025
Open
1 task
openclouders pushed a commit that referenced this pull request Dec 18, 2025
@tammi-23
Merge pull request #1687 from opencloud-eu/feat/1609
e87f007 
Mail: Mail compose as Widget #1609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

No one assigned

Labels

Type:Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tammi-23 @AlexAndBear @kulmann @JammingBen