-
Notifications
You must be signed in to change notification settings - Fork 25
fix: hide calendar when env var FRONTEND_DISABLE_RADICALE is set to true #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements conditional rendering of calendar-related UI elements based on the FRONTEND_DISABLE_RADICALE environment variable. When this variable is set to true, the calendar menu item and account calendar navigation are hidden from the user interface.
Key Changes:
- Added
support-radicalecapability to control calendar feature visibility - Conditionally rendered calendar navigation items and app menu extensions based on the capability
- Updated OpenCloud commit ID reference
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/pages/account/accountLayout.vue | Modified to conditionally render calendar navigation item based on supportRadicale capability |
| packages/web-runtime/src/extensions.ts | Updated to conditionally include calendar app menu extension when radicale is supported |
| packages/web-pkg/src/composables/piniaStores/capabilities.ts | Added supportRadicale computed property to expose the radicale support capability |
| packages/web-client/src/ocs/capabilities.ts | Added support-radicale boolean property to the core capabilities interface |
| .woodpecker.env | Updated OpenCloud commit ID to latest version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
…rue (#1660) * fix: hide calendar when env var FRONTEND_DISABLE_RADICALE is set to true
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Description
Related Issue
How Has This Been Tested?
Types of changes