fix: editing and loading tags for received shares #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with editing and loading versions for received shares by adjusting permission checks and resource loading logic. The changes ensure that incoming share resources are properly handled when determining edit capabilities and version loading.
Key changes:
- Updated permission checks for editing tags on incoming share resources
- Modified resource loading logic to handle both incoming and outgoing share resources
- Expanded permission criteria for tag editing in general resource builder
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-pkg/src/components/SideBar/FileSideBar.vue | Imports isOutgoingShareResource helper and updates resource loading condition to explicitly check for outgoing/incoming share resources |
| packages/web-client/src/helpers/share/functions.ts | Changes tag editing permission check from createChildren to createUpload for incoming share resources |
| packages/web-client/src/helpers/resource/functions.ts | Adds FolderCreateable permission as an additional criterion for tag editing capability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
changed the title
JammingBen
force-pushed
the
fix/share-tag-edit
branch
from
b923ad9 to
33071cb
Compare
kulmann
approved these changes
Nov 21, 2025
openclouders
pushed a commit
that referenced
this pull request
Nov 21, 2025
fix: editing and loading tags for received shares
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1635