fix: embed mode click behavior #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
fix/embed-click-behavior
branch
3 times, most recently
from
fb83f67 to
4ce8fa1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes click behavior issues in embed mode by consolidating shared logic between table and tiles views, addressing problems with file selection, navigation, and the file picker functionality.
Key Changes:
- Introduced
useResourceViewHelperscomposable to centralize click handling logic for both ResourceTable and ResourceTiles components - Fixed tile view to properly handle file picker mode by hiding the select-all checkbox and preventing unintended file downloads
- Removed deprecated
useToggleTilecomposable in favor of the new shared helper functions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-pkg/src/composables/resources/useResourceViewHelpers.ts |
New composable consolidating click handling logic for file containers, file names, and checkboxes |
packages/web-pkg/src/composables/resources/index.ts |
Exports new useResourceViewHelpers composable |
packages/web-pkg/src/composables/selection/useToggleTile.ts |
Removed deprecated composable, replaced by useResourceViewHelpers |
packages/web-pkg/src/composables/selection/index.ts |
Removed export of deprecated useToggleTile |
packages/web-pkg/src/components/FilesList/ResourceTiles.vue |
Refactored to use new helper composable, added file picker checkbox hiding |
packages/web-pkg/src/components/FilesList/ResourceTile.vue |
Updated event emissions to use new naming convention |
packages/web-pkg/src/components/FilesList/ResourceTable.vue |
Refactored to use new helper composable, simplified click handlers |
packages/web-pkg/tests/unit/components/FilesList/ResourceTiles.spec.ts |
Updated test to reflect new event emission names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-pkg/src/composables/resources/useResourceViewHelpers.ts
Outdated
Show resolved
Hide resolved
Fixes several issues with the click behavior in the embed mode. - hide select all checkbox in tiles view with file picker enabled - fix click behavior in tiles view with embed enabled - make tiles not selectable via keyboard with file picker enabled - prevent files from getting downloaded when selecting them in table view with file picker enabled Moves quite a bit of shared logic between the table and the tiles view into one helper composable.
JammingBen
force-pushed
the
fix/embed-click-behavior
branch
from
4ce8fa1 to
6d952a2
Compare
kulmann
requested changes
Nov 25, 2025
| :src="resource.thumbnail" | ||
| :data-test-thumbnail-resource-name="resource.name" | ||
| @click="toggleTile([resource, $event])" | ||
| @click.stop="$emit('tileClicked', [resource, $event])" |
Contributor
There was a problem hiding this comment.
I don't understand why tileClicked exists, it is never consumed anywhere 🙈
Contributor
Author
There was a problem hiding this comment.
It's consumed in the ResourceTiles component.
Contributor
There was a problem hiding this comment.
Ah, didn't check for @tile-clicked... -.- sorry for the noise
openclouders
pushed a commit
that referenced
this pull request
Dec 2, 2025
fix: embed mode click behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues with the click behavior in the embed mode.
Moves quite a bit of shared logic between the table and the tiles view into one helper composable. Mainly the ones for clicking files (or their containers/checkboxes).
fixes #1628
part of #1518