-
Notifications
You must be signed in to change notification settings - Fork 25
feat: share links and passwords in embed mode #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: share links and passwords in embed mode #1613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the embed mode functionality by allowing the parent application to receive both share links and passwords when creating links, rather than only copying them to the clipboard. The change enables better integration scenarios, such as inserting links with passwords directly into chat messages or emails.
- Modified the "Copy link and password" button behavior in embed mode to emit structured data to the parent application
- Introduced a new event
owncloud-embed:share-linksthat includes both URLs and optional passwords - Maintained backward compatibility by keeping the deprecated
opencloud-embed:shareevent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8b800d6 to
5538d1f
Compare
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
feat: share links and passwords in embed mode
Description
Change the "copy link and password" action in CreateLinkModal in embed mode to actually pass link(s) and password(s) to the parent application.
Related Issue
This is not the expected outcome, but I think it's the better solution. The ticket suggest to remove the button, I think it's better to pass the password with the url to the parent application. That way the parent application can insert the password with the link into a chat message or an email.
Yes, second channel would be better - but let's be honest, being forced to use a password in the default configuration is annoying enough for most users (me included).
How Has This Been Tested?
postMessage<Array<{ url: string; password?: string }>>withconsole.logand open OpenCloud with?embed=trueTypes of changes