Skip to content

Conversation

@dschmidt
Copy link
Contributor

Description

Change the "copy link and password" action in CreateLinkModal in embed mode to actually pass link(s) and password(s) to the parent application.

Related Issue

  • Fixes "Copy link and password" action makes no sense when creating multiple links #1592
    This is not the expected outcome, but I think it's the better solution. The ticket suggest to remove the button, I think it's better to pass the password with the url to the parent application. That way the parent application can insert the password with the link into a chat message or an email.
    Yes, second channel would be better - but let's be honest, being forced to use a password in the default configuration is annoying enough for most users (me included).

How Has This Been Tested?

  • using it in a roundcube plugin I'm working on :)
  • easiest way to test this is to replace postMessage<Array<{ url: string; password?: string }>> with console.log and open OpenCloud with ?embed=true

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copilot AI review requested due to automatic review settings November 13, 2025 15:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the embed mode functionality by allowing the parent application to receive both share links and passwords when creating links, rather than only copying them to the clipboard. The change enables better integration scenarios, such as inserting links with passwords directly into chat messages or emails.

  • Modified the "Copy link and password" button behavior in embed mode to emit structured data to the parent application
  • Introduced a new event owncloud-embed:share-links that includes both URLs and optional passwords
  • Maintained backward compatibility by keeping the deprecated opencloud-embed:share event

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dschmidt dschmidt force-pushed the feat/share-links-and-passswords branch from 8b800d6 to 5538d1f Compare November 13, 2025 16:26
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JammingBen JammingBen merged commit d8fa1e7 into opencloud-eu:main Nov 14, 2025
29 checks passed
openclouders pushed a commit that referenced this pull request Nov 14, 2025
feat: share links and passwords in embed mode
@openclouders openclouders mentioned this pull request Nov 14, 2025
1 task
@openclouders openclouders mentioned this pull request Dec 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Copy link and password" action makes no sense when creating multiple links

2 participants