fix: embed actions z-index #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the embed actions from overlapping notifications. This was done intentionally in the past because the empty notification zone would still render a margin, making the actions hard to click. The margin now only applies when there are notifications showing.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses z-index stacking issues with embed actions by removing an unnecessarily high z-index value and migrating a component to Vue 3's script setup syntax. The changes ensure proper visual layering of UI elements while modernizing the codebase.
Key changes:
- Removed excessive z-index from EmbedActions component that was causing it to appear above modal overlays
- Migrated EmbedActions.vue from Options API to Composition API with script setup
- Adjusted notification spacing by moving margin-bottom class from OcNotifications to its parent MessageBar component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-app-files/src/components/EmbedActions/EmbedActions.vue | Removed problematic z-index class and refactored from Options API to script setup, removing unused ability import |
| packages/web-runtime/src/components/MessageBar.vue | Added conditional bottom margin to notifications wrapper when messages are present |
| packages/design-system/src/components/OcNotifications/OcNotifications.vue | Removed bottom margin class to allow parent components to control spacing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kulmann
approved these changes
Nov 17, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
openclouders
pushed a commit
that referenced
this pull request
Nov 17, 2025
fix: embed actions z-index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 45bfb5a for the actual change.
fixes #1591