[stable-4.2] fix: initial default favicon

index.html

@@ -8,6 +8,7 @@
 
     <title><%= data.title %></title>
     <link rel="manifest" href="manifest.json" crossorigin="use-credentials" />
+    <link rel="icon" href="img/favicon.svg" />
     <% if (data.buildConfig.cdn) { %>
     <script src="//cdnjs.cloudflare.com/ajax/libs/require.js/2.3.7/require.min.js"></script>
     <script>

packages/web-pkg/src/composables/piniaStores/theme.ts

@@ -64,6 +64,16 @@ export type ThemeConfigType = z.infer<typeof ThemeConfig>
 
 const themeStorageKey = 'oc_currentThemeName'
 
+const setFavicon = (url: string) => {
+  let link = document.querySelector("link[rel~='icon']") as HTMLLinkElement
+  if (!link) {
+    link = document.createElement('link')
+    link.rel = 'icon'
+    document.head.appendChild(link)
+  }
+  link.href = url
+}
+
 export const useThemeStore = defineStore('theme', () => {
   const currentLocalStorageThemeName = useLocalStorage(themeStorageKey, null)
 
@@ -130,6 +140,10 @@ export const useThemeStore = defineStore('theme', () => {
       applyCustomProp('role-chrome', unref(currentTheme).designTokens?.roles?.surfaceContainer)
       applyCustomProp('role-on-chrome', unref(currentTheme).designTokens?.roles?.onSurface)
     }
+
+    if (unref(currentTheme).favicon) {
+      setFavicon(unref(currentTheme).favicon)
+    }
   }
 
   const getRoleIcon = (role: ShareRole) => {

packages/web-runtime/src/composables/head/useHead.ts

@@ -1,29 +1,19 @@
-import { computed, unref } from 'vue'
+import { computed } from 'vue'
 import { useHead as _useHead } from '@vueuse/head'
 import { getBackendVersion, getWebVersion } from '../../container/versions'
-import { useCapabilityStore, useThemeStore } from '@opencloud-eu/web-pkg'
-import { storeToRefs } from 'pinia'
+import { useCapabilityStore } from '@opencloud-eu/web-pkg'
 
 export const useHead = () => {
-  const themeStore = useThemeStore()
   const capabilityStore = useCapabilityStore()
-  const { currentTheme } = storeToRefs(themeStore)
 
-  const favicon = computed(() => unref(currentTheme).favicon)
-
-  _useHead(
-    computed(() => {
-      return {
-        meta: [
-          {
-            name: 'generator',
-            content: [getWebVersion(), getBackendVersion({ capabilityStore })]
-              .filter(Boolean)
-              .join(', ')
-          }
-        ],
-        ...(unref(favicon) && { link: [{ rel: 'icon', href: unref(favicon) }] })
+  _useHead({
+    meta: computed(() => [
+      {
+        name: 'generator',
+        content: [getWebVersion(), getBackendVersion({ capabilityStore })]
+          .filter(Boolean)
+          .join(', ')
       }
-    })
-  )
+    ])
+  })
 }