fix: initial default favicon #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the OpenCloud logo as default favicon until the theme favicon is loaded. This fixes an issue where OpenCloud would not have any bookmark icon in Firefox due to the initially missing favicon. Unfortunately, we can't use `vueuse/head` because it would result in a duplicated `<link rel="">` tag.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing bookmark icon issue in Firefox by introducing a default OpenCloud logo favicon that displays immediately on page load, which is then replaced by the theme-specific favicon once the theme is loaded.
- Adds a default favicon link in the HTML head
- Moves favicon management from the
useHeadcomposable to the theme store using direct DOM manipulation - Simplifies the
useHeadcomposable to only manage meta tags
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| index.html | Adds a default favicon link pointing to the OpenCloud logo SVG |
| packages/web-container/img/favicon.svg | New default favicon file containing the OpenCloud logo |
| packages/web-runtime/src/composables/head/useHead.ts | Removes favicon management and theme store dependencies, simplifies to only handle meta tags |
| packages/web-pkg/src/composables/piniaStores/theme.ts | Adds setFavicon function for dynamic favicon updates and calls it when theme is applied |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexAndBear
approved these changes
Nov 11, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
openclouders
pushed a commit
that referenced
this pull request
Nov 11, 2025
fix: initial default favicon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the OpenCloud logo as default favicon until the theme favicon is loaded. This fixes an issue where OpenCloud would not have any bookmark icon in Firefox due to the initially missing favicon.
Unfortunately, we can't use
vueuse/headbecause it would result in a duplicated<link rel="">tag.fixes #1125