fix: add missing file list update after undo delete in space #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the isItemInCurrentFolder helper function by moving it from web-runtime to web-pkg to improve code reusability and maintainability across the codebase.
- Moved
isItemInCurrentFolderhelper fromweb-runtime/src/container/sse/helpers.tstoweb-pkg/src/helpers/resource/isItemInCurrentFolder.ts - Relocated associated tests from
web-runtime/tests/unit/container/sse/helpers.spec.tstoweb-pkg/tests/unit/helpers/resource/isItemInCurrentFolder.spec.ts - Updated all import statements across files to use the new location from
@opencloud-eu/web-pkg
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/tests/unit/container/sse/helpers.spec.ts | Removed isItemInCurrentFolder tests and related imports (SpaceResource, isItemInCurrentFolder) |
| packages/web-runtime/src/container/sse/shares.ts | Updated import to use isItemInCurrentFolder from @opencloud-eu/web-pkg instead of local helpers |
| packages/web-runtime/src/container/sse/helpers.ts | Removed isItemInCurrentFolder function and its dependencies |
| packages/web-runtime/src/container/sse/files.ts | Updated import to use isItemInCurrentFolder from @opencloud-eu/web-pkg instead of local helpers |
| packages/web-pkg/tests/unit/helpers/resource/isItemInCurrentFolder.spec.ts | Added comprehensive test suite for isItemInCurrentFolder (moved from web-runtime) |
| packages/web-pkg/src/helpers/resource/isItemInCurrentFolder.ts | Added isItemInCurrentFolder helper function implementation |
| packages/web-pkg/src/helpers/resource/index.ts | Exported isItemInCurrentFolder from resource helpers |
| packages/web-pkg/src/composables/actions/files/useFileActionsUndoDelete.ts | Refactored to use isItemInCurrentFolder helper instead of direct comparison for improved robustness |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-pkg/tests/unit/helpers/resource/isItemInCurrentFolder.spec.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/tests/unit/helpers/resource/isItemInCurrentFolder.spec.ts
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/undo-delete-file-list-update
branch
from
b2bf7a6 to
d416ac4
Compare
kulmann
approved these changes
Nov 10, 2025
openclouders
pushed a commit
that referenced
this pull request
Nov 10, 2025
…update fix: add missing file list update after undo delete in space
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to move
isItemInCurrentFolderfrom the runtime to web-pkg.fixes #1522