Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

related #792
added some missed test.

Copilot AI review requested due to automatic review settings November 4, 2025 12:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to verify that a user's profile photo is visible in the admin settings users management page. The change supports testing the admin's ability to view user profile pictures after they have been uploaded.

  • Adds getUserProfilePicture method to retrieve a user's profile picture locator from the admin settings users table
  • Implements a Cucumber step to verify profile photo visibility in admin settings
  • Updates the profile photo feature test to include admin verification scenario

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/e2e/support/objects/app-admin-settings/users/index.ts Adds getUserProfilePicture method to Users class and imports Locator type
tests/e2e/support/objects/app-admin-settings/users/actions.ts Implements getUserProfilePicture action with avatar selector and imports Locator type
tests/e2e/cucumber/steps/ui/adminSettings.ts Implements Cucumber step to verify user profile photo visibility in admin settings
tests/e2e/cucumber/features/user-settings/profilePhoto.feature Adds test scenario for admin to verify user's profile photo after upload

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ScharfViktor ScharfViktor force-pushed the checkUserAvatarInUserManagement branch from 5ba5345 to 62a2397 Compare November 4, 2025 12:12
@AlexAndBear AlexAndBear merged commit 3d9dec7 into main Nov 4, 2025
28 checks passed
@AlexAndBear AlexAndBear deleted the checkUserAvatarInUserManagement branch November 4, 2025 12:30
@openclouders openclouders mentioned this pull request Nov 4, 2025
1 task
AlexAndBear pushed a commit that referenced this pull request Nov 4, 2025
@AlexAndBear
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
stable-4.2

Questions ?

Please refer to the Backport tool documentation

ScharfViktor added a commit that referenced this pull request Nov 4, 2025
(cherry picked from commit 3d9dec7)

Co-authored-by: Viktor Scharf <scharf.vi@gmail.com>
@openclouders openclouders mentioned this pull request Nov 5, 2025
1 task
@openclouders openclouders mentioned this pull request Dec 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants