fix: only render drop content when opened #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the useFileListHeaderPosition composable to defer the initial refresh call until after the next Vue tick when the component is mounted. Previously, refresh() was called directly in onMounted; now it's wrapped in an async callback that awaits nextTick() before calling refresh().
- Wraps the
onMountedrefresh call in an async function that awaitsnextTick()before executing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-pkg/src/composables/fileListHeaderPosition/useFileListHeaderPosition.ts
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/table-header-offset
branch
from
bd3665d to
68afbf1
Compare
JammingBen
changed the title
JammingBen
force-pushed
the
fix/table-header-offset
branch
from
68afbf1 to
3e451ff
Compare
JammingBen
changed the title
This fixes a small UI glitch when closing the file context menu and an unwanted displacement of the table header row in certain edge cases.
JammingBen
force-pushed
the
fix/table-header-offset
branch
from
3271965 to
5027331
Compare
JammingBen
commented
Nov 4, 2025
Comment on lines
-56
to
-74
| it.each<SizeType | 'remove'>([ | ||
| 'xsmall', | ||
| 'small', | ||
| 'medium', | ||
| 'large', | ||
| 'xlarge', | ||
| 'xxlarge', | ||
| 'remove' | ||
| ])('handles padding size prop for value %s', async (size) => { | ||
| const { wrapper } = dom({ paddingSize: size }) | ||
|
|
||
| const drop = wrapper.findComponent({ name: 'oc-drop' }) | ||
| await nextTick() | ||
|
|
||
| const tailwindClassObj = getTailwindPaddingClass(size) | ||
| const tailwindClass = Object.entries(tailwindClassObj).find(([, v]) => v)?.[0] | ||
| expect(drop.html().includes(tailwindClass)).toBeTruthy() | ||
| }) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I added a dedicated unit test for getTailwindPaddingClass instead of testing it implicitly here.
JammingBen
force-pushed
the
fix/table-header-offset
branch
from
5027331 to
4a41c21
Compare
kulmann
approved these changes
Nov 5, 2025
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
thanks for the fix, seems to work 💪
openclouders
pushed a commit
that referenced
this pull request
Nov 5, 2025
fix: only render drop content when opened
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small UI glitch when closing the file context menu and an unwanted displacement of the table header row in certain edge cases.
fixes #1477