feat: show line numbers in text/markdown editor, fix lists not rendered correctly #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds line number support to the markdown editor by integrating CodeMirror's line numbers extension.
Key Changes:
- Added
@codemirror/viewdependency to enable line numbers functionality - Integrated line numbers into the text editor extensions array
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-pkg/package.json | Added @codemirror/view dependency for line numbers support |
| packages/web-pkg/src/components/TextEditor/TextEditor.vue | Imported and configured line numbers extension in the editor |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kulmann
reviewed
Oct 28, 2025
| return [ | ||
| ...extensions, | ||
| { | ||
| type: 'lineNumbers', |
Contributor
There was a problem hiding this comment.
not everybody likes line numbers.. possible to make them optional?
Contributor
Author
There was a problem hiding this comment.
We would need a new toolbar extension for that, possibly doable in a follow up
AlexAndBear
changed the title
github-project-automation
bot
moved this from In Progress
to Done
in OpenCloud Team Board
JammingBen
reviewed
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes