fix: set space image action showing outside of project spaces

packages/web-pkg/src/composables/actions/files/useFileActionsSetImage.ts

@@ -1,5 +1,4 @@
 import { isLocationSpacesActive } from '../../../router'
-import { usePreviewService } from '../../previewService'
 import { useClientService } from '../../clientService'
 import { useLoadingService } from '../../loadingService'
 import { useRouter } from '../../router'
@@ -8,14 +7,14 @@ import { computed } from 'vue'
 import { FileAction, FileActionOptions } from '../types'
 import { useModals, useUserStore } from '../../piniaStores'
 import SpaceImageModal from '../../../components/Spaces/SpaceImageModal.vue'
+import { isProjectSpaceResource } from '@opencloud-eu/web-client'
 
 export const useFileActionsSetImage = () => {
   const userStore = useUserStore()
   const router = useRouter()
   const { $gettext } = useGettext()
   const clientService = useClientService()
   const loadingService = useLoadingService()
-  const previewService = usePreviewService()
   const { dispatchModal } = useModals()
 
   const handler = async ({ space, resources }: FileActionOptions) => {
@@ -56,7 +55,9 @@ export const useFileActionsSetImage = () => {
         if (!space) {
           return false
         }
-
+        if (!isProjectSpaceResource(space)) {
+          return false
+        }
         return space.canEditImage({ user: userStore.user })
       },
       class: 'oc-files-actions-set-space-image-trigger'

packages/web-pkg/tests/unit/composables/actions/files/useFileActionsSetImage.spec.ts

@@ -38,6 +38,15 @@ describe('setImage', () => {
         }
       })
     })
+    it.each(['personal', 'share'])('should be false when space is of type %s', (driveType) => {
+      const space = mock<SpaceResource>({ canEditImage: () => true, driveType })
+
+      getWrapper({
+        setup: ({ actions }) => {
+          expect(unref(actions)[0].isVisible({ space, resources: [space] })).toBe(false)
+        }
+      })
+    })
   })
 
   describe('handler', () => {