fix: add missing first breadcrumb on table size screens #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a breadcrumb display issue on tablet-sized screens where the first breadcrumb item was not being shown. The fix ensures that breadcrumbs are displayed correctly when only a single item is present, and updates the layout logic to handle single vs. multiple breadcrumb items appropriately.
Key changes:
- Modified the breadcrumb component to display single breadcrumb items on mobile/tablet screens
- Refactored the General.vue component from Options API to Composition API with
<script setup> - Fixed a flaky unit test by adding missing mock stubs
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue |
Changed visibility condition from length > 1 to length and made justify-center conditional on having multiple items |
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.spec.ts |
Removed test case for single breadcrumb item not showing, as it now should be displayed |
packages/design-system/src/components/OcBreadcrumb/__snapshots__/OcBreadcrumb.spec.ts.snap |
Updated snapshots to reflect class order change with conditional justify-center |
packages/web-app-admin-settings/src/views/General.vue |
Refactored from Options API to Composition API, removed parent breadcrumb and inlined breadcrumb definition |
packages/web-app-admin-settings/tests/unit/views/__snapshots__/General.spec.ts.snap |
Updated snapshot reflecting single breadcrumb item instead of two |
packages/web-app-files/tests/unit/components/Spaces/SpaceHeader.spec.ts |
Added TextEditor mock and stub to fix flaky test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
commented
Oct 27, 2025
JammingBen
force-pushed
the
fix/missing-first-breadcrumb
branch
2 times, most recently
from
c719dd3 to
ec66d34
Compare
kulmann
force-pushed
the
fix/missing-first-breadcrumb
branch
from
ec66d34 to
0343689
Compare
openclouders
pushed a commit
that referenced
this pull request
Nov 3, 2025
fix: add missing first breadcrumb on table size screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1436 (and a flaky unit test).