Skip to content

Conversation

@ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Oct 24, 2025

I fixed two problems:

  1. Wait #files-folder-upload-input before starting upload data

sometimes we got error:

locator.setInputFiles: Timeout 30000ms exceeded.
       Call log:
         - waiting for locator('#files-folder-upload-input')
           - locator resolved to <input type="file" name="file" tabindex="-1" listener="true" allowdirs="true" webkitdirectory="" mozdirectory="true" id="files-folder-upload-input" class="absolute left-[99999px]" aria-labelledby="files-folder-upload-button"/>
  1. skip checking console err for mobile tests

Copilot AI review requested due to automatic review settings October 24, 2025 10:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses timing issues in end-to-end tests related to file and folder uploads, particularly for webkit mobile environments. The changes ensure that upload input elements are properly attached to the DOM before attempting to interact with them.

Key Changes:

  • Added explicit wait for upload input element attachment before calling setInputFiles()
  • Enabled CSP bypass for mobile webkit browser context to resolve upload-related issues

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/e2e/support/objects/app-files/resource/actions.ts Adds waitFor call to ensure upload input is attached before file upload
tests/e2e/support/environment/actor/shared.ts Enables bypassCSP for mobile webkit device configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ScharfViktor ScharfViktor force-pushed the fix/upload-input-timeout branch 2 times, most recently from a441383 to 3e09190 Compare October 24, 2025 11:02
@ScharfViktor
Copy link
Contributor Author

I restarted CI a couple of times. https://ci.opencloud.eu/repos/6/pipeline/97/191 seems it works

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ScharfViktor ScharfViktor force-pushed the fix/upload-input-timeout branch from 6a254df to bf0cc09 Compare October 24, 2025 12:13
@ScharfViktor ScharfViktor merged commit c20864a into main Oct 24, 2025
28 checks passed
@ScharfViktor ScharfViktor deleted the fix/upload-input-timeout branch October 24, 2025 19:40
@openclouders openclouders mentioned this pull request Oct 24, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants