fix: view options and breadcrumbs on mobile with right sidebar #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to the mobile versions of the view options and the breadcrumbs one breakpoint earlier if the right sidebar is open.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the display of view options and breadcrumbs on mobile devices when the right sidebar is open. The main change adjusts responsive breakpoints to switch to mobile layouts one step earlier (from sm to md) when the sidebar is active, preventing layout overflow issues.
- Refactored
ViewOptions.vuefrom Options API to Composition API (<script setup>) - Added dynamic breakpoint adjustment based on sidebar state for both breadcrumbs and view options
- Introduced
mobileBreakpointprop toOcBreadcrumbcomponent for configurable responsive behavior
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-pkg/src/components/ViewOptions.vue |
Converted to Composition API and added dynamic breakpoint classes based on sidebar state |
packages/web-pkg/tests/unit/components/ViewOptions.spec.ts |
Added type assertions for refactored component |
packages/web-pkg/src/components/AppBar/AppBar.vue |
Added dynamic mobile-breakpoint prop to breadcrumb based on sidebar state |
packages/web-app-admin-settings/src/components/AppTemplate.vue |
Added dynamic mobile-breakpoint prop to breadcrumb based on sidebar state |
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue |
Added mobileBreakpoint prop with dynamic class application |
packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.spec.ts |
Added tests for new mobileBreakpoint prop functionality |
packages/design-system/src/components/OcBreadcrumb/__snapshots__/OcBreadcrumb.spec.ts.snap |
Updated snapshots for reordered CSS classes |
packages/web-app-admin-settings/tests/unit/views/__snapshots__/Users.spec.ts.snap |
Updated snapshots with new mobilebreakpoint attribute |
packages/web-app-admin-settings/tests/unit/views/__snapshots__/Spaces.spec.ts.snap |
Updated snapshots with new mobilebreakpoint attribute |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the mobile versions of the view options and the breadcrumbs one breakpoint earlier if the right sidebar is open.
fixes #1392