Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 21, 2025

Adds a password modal that prompts the user for a password when changing the role from viewer to editor and the editor role is configured to require a password.

To review the actual change: b6112e2

fixes #1379

@JammingBen JammingBen self-assigned this Oct 21, 2025
Copilot AI review requested due to automatic review settings October 21, 2025 14:03
@JammingBen JammingBen changed the title Fix/password link enforcement fix: password link enforcement Oct 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Vue components to use the Composition API (<script setup>) syntax instead of the Options API, while fixing a bug where password enforcement was incorrectly determined based on the current link type rather than the target link type when changing roles.

Key Changes:

  • Replaced isPasswordEnforced prop with dynamic isPasswordEnforcedForLinkType() check using the target type
  • Converted ListItem.vue and FileLinks.vue from Options API to Composition API syntax
  • Removed unused isPasswordEnforced prop from ListItem component

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/web-app-files/src/components/SideBar/Shares/Links/ListItem.vue Converted to Composition API and replaced static isPasswordEnforced prop with dynamic isPasswordEnforcedForLinkType(type) check
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Converted to Composition API and removed isPasswordEnforced prop binding

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Adds a password modal that prompts the user for a password when changing the role from viewer to editor and the editor role is configured to require a password.
@JammingBen JammingBen force-pushed the fix/password-link-enforcement branch from 91f7638 to feb3f60 Compare October 21, 2025 14:06
@JammingBen JammingBen merged commit 55f3371 into main Oct 27, 2025
28 checks passed
@JammingBen JammingBen deleted the fix/password-link-enforcement branch October 27, 2025 05:57
@openclouders openclouders mentioned this pull request Oct 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public link password enforcement only for writeable links

3 participants