Skip to content

Conversation

@JammingBen
Copy link
Contributor

fixes #1359

@JammingBen JammingBen self-assigned this Oct 20, 2025
Copilot AI review requested due to automatic review settings October 20, 2025 12:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix sidebar affecting tile size by reacting to sidebar open state and preventing invalid CSS variable updates.

  • Add a guard to avoid setting the tile size CSS variable when the value is invalid.
  • Trigger tile width recalculation when the sidebar opens/closes.
  • Add a FIXME in useSideBar noting the need for a global store to avoid duplicate listeners.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/web-pkg/src/composables/sideBar/useSideBar.ts Adds a FIXME comment referencing migrating to a global store to prevent multiple event listeners.
packages/web-pkg/src/components/FilesList/ResourceTiles.vue Imports useSideBar, watches sidebar open state to recalc view width, and guards setting the CSS variable only when tile size is valid.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the fix/sidebar-tilesize-change branch from d2504db to a576a43 Compare October 20, 2025 12:29
@JammingBen JammingBen force-pushed the fix/sidebar-tilesize-change branch from a576a43 to 194ef7c Compare October 20, 2025 12:58
@JammingBen JammingBen merged commit 69dbfdd into main Oct 21, 2025
28 checks passed
@JammingBen JammingBen deleted the fix/sidebar-tilesize-change branch October 21, 2025 05:33
@openclouders openclouders mentioned this pull request Oct 21, 2025
1 task
openclouders pushed a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar can mess with the current tile size

3 participants