feat(external): respect light/dark theme in Collabora #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements light/dark theme support for Collabora integration by respecting the current theme setting and removing the internal theme switch within Collabora.
- Adds theme detection and UI defaults parameter to pass theme preference to Collabora
- Hides Collabora's internal dark theme toggle button via post message
- Updates test suite to verify theme parameter is correctly set based on current theme
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-app-external/src/App.vue | Implements theme detection, adds UI defaults parameter, and hides Collabora's theme toggle |
| packages/web-app-external/tests/unit/app.spec.ts | Adds comprehensive tests for theme functionality and updates test helper function |
| packages/web-app-external/tests/unit/snapshots/app.spec.ts.snap | Updates snapshot to reflect new hidden input field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexAndBear
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And removes the light/dark theme switch within Collabora.
closes #705