Skip to content

Conversation

@JammingBen
Copy link
Contributor

We decided to remove the click handler because it just opened the right sidebar for, which is not really a connected to the share avatars.

fixes #1329

We decided to remove the click handler because it just opened the right sidebar for, which is not really a connected to the share avatars.
@JammingBen JammingBen self-assigned this Oct 9, 2025
Copilot AI review requested due to automatic review settings October 9, 2025 09:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the click handler functionality from share avatars in the files table. The click handler previously opened the right sidebar when users clicked on share avatars, but this functionality was deemed unconnected to the actual purpose of the share avatars.

  • Removed click handlers from both "sharedBy" and "sharedWith" avatar components
  • Deleted the openSharingSidebar method that was handling the click events
  • Updated test selectors to use data-testid attributes instead of CSS classes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/web-pkg/src/components/FilesList/ResourceTable.vue Removed oc-button wrappers and openSharingSidebar method from share avatar components
packages/web-pkg/tests/unit/components/FilesList/ResourceTable.spec.ts Updated test selectors to use data-testid instead of CSS class selectors

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen merged commit 93386b2 into main Oct 9, 2025
28 checks passed
@JammingBen JammingBen deleted the fix/remove-share-avatar-click-handler branch October 9, 2025 12:00
openclouders pushed a commit that referenced this pull request Oct 9, 2025
…ick-handler

fix: remove share avatar click handler in files table
@openclouders openclouders mentioned this pull request Oct 9, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking "Shared by/with" avatars is pointless

3 participants