Skip to content

Conversation

@saw-jan
Copy link
Contributor

@saw-jan saw-jan commented Oct 9, 2025

Description

Define and use keycloak admin wherever needed, and separate it from opencloud admin.

Related Issue

How Has This Been Tested?

  • 🖥️
  • 🤖

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@saw-jan saw-jan self-assigned this Oct 9, 2025
@saw-jan saw-jan force-pushed the test/fix-keycloak-test branch from 6480c5d to 929e97c Compare October 9, 2025 11:22
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan saw-jan force-pushed the test/fix-keycloak-test branch from 929e97c to 54b83a1 Compare October 10, 2025 04:17
@saw-jan saw-jan marked this pull request as ready for review October 10, 2025 05:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates the concerns of Keycloak admin user management from OpenCloud admin user management in the e2e test framework. It introduces a dedicated function to create Keycloak admin user objects and updates all relevant API calls to use this specific admin user instead of the generic admin user.

  • Creates a new getKeycloakAdminUser() function that returns a properly structured admin user object
  • Replaces all calls to getAdminUser() with getKeycloakAdminUser() in Keycloak API operations
  • Refactors token management functions to work specifically with the Keycloak admin user

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/e2e/support/utils/tokenHelper.ts Reorders function parameters for better consistency
tests/e2e/support/utils/index.ts Exports the tokenHelper module
tests/e2e/support/api/keycloak/utils.ts Replaces setupKeycloakAdminUser with getKeycloakAdminUser function
tests/e2e/support/api/keycloak/user.ts Updates all Keycloak API calls to use the dedicated admin user
tests/e2e/support/api/keycloak/openCloudUserToken.ts Refactors token management functions for Keycloak admin user
tests/e2e/cucumber/environment/index.ts Updates test setup and teardown to use new admin token functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@saw-jan saw-jan requested a review from Copilot October 10, 2025 05:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit c0bce60 into main Oct 10, 2025
28 checks passed
@saw-jan saw-jan deleted the test/fix-keycloak-test branch October 10, 2025 08:17
@openclouders openclouders mentioned this pull request Oct 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants