feat: add tiles view for shared with others view #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tiles view support for the "shared with others" view by implementing a new folder view extension point and integrating view mode switching capabilities.
- Creates a new extension point for shared with others folder views
- Updates the SharedWithOthers component to support dynamic view modes and folder view components
- Adds necessary test infrastructure to support the new folder view extensions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/web-app-files/src/extensionPoints.ts | Adds new extension point for shared with others folder views |
| packages/web-app-files/src/composables/extensions/useFolderViews.ts | Includes the new extension point in existing folder view configurations |
| packages/web-app-files/src/views/shares/SharedWithOthers.vue | Implements dynamic view mode switching and folder view component rendering |
| packages/web-app-files/tests/unit/views/shares/SharedWithOthers.spec.ts | Updates test setup to mock extension registry and folder view extensions |
| tests/e2e/cucumber/features/user-settings/profilePhoto.feature | Adds test step to switch to table view |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| :header-position="fileListHeaderY" | ||
| :sort-by="sortBy" | ||
| :sort-dir="sortDir" | ||
| :sort-fields="sortFields.filter((field) => field.name === 'name')" |
There was a problem hiding this comment.
The inline filter operation creates a new array on every render. Consider memoizing this with computed() to improve performance.
JammingBen
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes