feat: add tiles view for shared via link view #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tiles view support to the "shared via link" view by implementing a folder view extension system. The change enables users to switch between different viewing modes (table, tiles, etc.) when viewing resources shared via link.
- Adds tiles view extension support to the SharedViaLink component
- Updates the extension points to include shared via link views
- Modifies test setup to mock the extension registry properly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SharedViaLink.spec.ts | Updates test setup to mock extension registry and folder view extensions |
| SharedViaLink.vue | Refactors component to use dynamic folder views instead of hardcoded ResourceTable |
| extensionPoints.ts | Adds new extension point for shared via link folder views |
| useFolderViews.ts | Includes shared via link extension point in all folder view configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| describe('different files view states', () => { | ||
| it('shows the loading spinner during loading', () => { | ||
| const { wrapper } = getMountedWrapper({ loading: true }) | ||
| console.log(wrapper.html()) |
There was a problem hiding this comment.
Debug console.log statement should be removed before merging to production.
packages/web-app-files/tests/unit/views/shares/SharedViaLink.spec.ts
Outdated
Show resolved
Hide resolved
JammingBen
approved these changes
Oct 9, 2025
Comment on lines
+126
to
+132
| const folderViewStyle = computed(() => { | ||
| return { | ||
| ...(unref(folderView)?.isScrollable === false && { | ||
| height: `calc(100% - ${unref(appBarRef)?.$el.getBoundingClientRect().height}px)` | ||
| }) | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
Since this is the same in every file view, maybe we could make this part of the resourcesViewDefaults in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes