fix: prevent uploading the same file again during upload #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Uppy wouldn't recognize files as new when uploading the same file multiple times by making upload IDs unique with timestamps. It also improves user experience by immediately updating the file list when top-level folders are created during upload.
- Appends a timestamp to generated upload IDs to ensure uniqueness for repeated file uploads
- Adds immediate file list updates for top-level folder creation to provide instant user feedback
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-pkg/src/services/uppy/uppyService.ts | Modifies upload ID generation to include timestamp for uniqueness |
| packages/web-app-files/src/HandleUpload.ts | Adds immediate file list update for top-level folder creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JammingBen
force-pushed
the
fix/upload-same-file-multiple-times
branch
5 times, most recently
from
ac6bef0 to
7c6639c
Compare
JammingBen
force-pushed
the
fix/upload-same-file-multiple-times
branch
from
7c6639c to
1684aae
Compare
JammingBen
changed the title
JammingBen
force-pushed
the
fix/upload-same-file-multiple-times
branch
from
1684aae to
8590601
Compare
Uploading the same file multiple times while the upload is still running causes issues because Uppy can not distinguish those files. Hence prevent this behavior. Also updates the file list immediately after a top-level folder has been created during upload so the user gets direct feedback about their upload. This comes in handy when uploading the same folder multiple times.
JammingBen
force-pushed
the
fix/upload-same-file-multiple-times
branch
from
8277c06 to
e64b08e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading the same file multiple times while the upload is still running causes issues because Uppy can not distinguish those files. Hence prevent this behavior.
Also updates the file list immediately after a top-level folder has been created during upload so the user gets direct feedback about their upload.
fixes #1263