Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen self-assigned this Sep 26, 2025
Copilot AI review requested due to automatic review settings September 26, 2025 07:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes type errors in the web-pkg package by adding missing type declarations and correcting type inconsistencies. The changes improve TypeScript compilation and ensure proper type safety across the codebase.

  • Adds missing type definitions and includes proper source files in TypeScript configuration
  • Fixes type parameter mismatches in table component event handlers
  • Updates build configuration to generate types with proper directory structure

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/web-pkg/vite.config.ts Updates DTS plugin configuration to specify entry root and output directory
packages/web-pkg/tsconfig.json Adds missing type declarations and source files to TypeScript includes
packages/web-pkg/src/components/FilesList/ResourceTable.vue Fixes parameter types for drag-drop handlers and event data processing
packages/design-system/src/components/OcTable/OcTable.vue Corrects component reference types in table row event emissions
packages/design-system/src/components/OcAvatars/OcAvatars.vue Adds missing userId property and slot type definitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen merged commit dcd5a96 into main Sep 26, 2025
29 checks passed
@JammingBen JammingBen deleted the chore/fix-web-pkg-types branch September 26, 2025 08:36
@openclouders openclouders mentioned this pull request Sep 26, 2025
1 task
openclouders pushed a commit that referenced this pull request Sep 26, 2025
fix: add missing web-pkg types and fix type errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web-pkg types are broken

3 participants