Skip to content

Conversation

@JammingBen
Copy link
Contributor

See commits for details.

refs #937

@JammingBen JammingBen self-assigned this Sep 18, 2025
Copilot AI review requested due to automatic review settings September 18, 2025 07:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several Tailwind CSS regressions by updating class names and styling configurations. The changes address styling inconsistencies and component appearance issues.

  • Remove outdated Tailwind class (w-sm) and modernize component setup
  • Update modal styling from rounded-sm to rounded-lg for consistency
  • Fix text editor font family inheritance using Tailwind arbitrary value syntax
  • Update search bar filter button styling to use design system properties

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/web-runtime/src/pages/missingOrInvalidConfig.vue Removes invalid w-sm class, adds conditional rendering, converts to script setup
packages/web-pkg/src/components/TextEditor/TextEditor.vue Adds font family inheritance using Tailwind arbitrary values
packages/web-pkg/src/components/SearchBarFilter.vue Updates button styling to use design system appearance and color properties
packages/design-system/src/components/OcModal/OcModal.vue Changes modal border radius from rounded-sm to rounded-lg
packages/design-system/src/components/OcModal/snapshots/OcModal.spec.ts.snap Updates test snapshots to reflect modal styling changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann kulmann merged commit e8aff32 into main Sep 18, 2025
29 checks passed
@kulmann kulmann deleted the fix/tailwind-regressions-3 branch September 18, 2025 08:45
openclouders pushed a commit that referenced this pull request Sep 18, 2025
@openclouders openclouders mentioned this pull request Sep 18, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants