Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen self-assigned this Sep 16, 2025
Copilot AI review requested due to automatic review settings September 16, 2025 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the line-height of resource names in the FilesList component by adding the leading-4 Tailwind CSS class. This addresses a visual issue with resource name display referenced in GitHub issue #937.

Key Changes

  • Added leading-4 class to ensure consistent line-height for resource names
  • Applied the fix to both truncated and non-truncated display modes
  • Updated test snapshots to reflect the CSS class changes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/web-pkg/src/components/FilesList/ResourceName.vue Added leading-4 class to spans containing resource names and extensions
packages/web-pkg/tests/unit/components/FilesList/snapshots/ResourceName.spec.ts.snap Updated snapshots to include the new leading-4 class in test expectations
packages/web-pkg/tests/unit/components/FilesList/snapshots/ResourceListItem.spec.ts.snap Updated snapshot to reflect the line-height fix in resource list item display

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen
Copy link
Contributor Author

@kulmann This fixes the vertical alignment of the resource names, especially in the top bar. It's still not 100% like before because the top bar height is now 40px (= h-10) instead of 42px (which would be h-10.5). To me it looks fine, what do you think?

The buttons still look cramped just because there are too many, especially with the auto save icon. But this is no regression from Tailwind. Still, do we want to do anything about that?

@JammingBen JammingBen requested a review from kulmann September 16, 2025 14:38
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good now 👍

@kulmann
Copy link
Contributor

kulmann commented Sep 17, 2025

The buttons still look cramped just because there are too many, especially with the auto save icon. But this is no regression from Tailwind. Still, do we want to do anything about that?

I think we discussed recently that we could/should get rid of the autosave-icon by using a different save-icon... but for that we'd need some sort of icon stacking I guess. Do you have other ideas?

@JammingBen
Copy link
Contributor Author

I think we discussed recently that we could/should get rid of the autosave-icon by using a different save-icon... but for that we'd need some sort of icon stacking I guess. Do you have other ideas?

The only other idea I have is to display an overlay in some corner during the process of auto-saving. But that's not an always visible indicator. Then again: how does the user benefit from this information?

@JammingBen JammingBen merged commit 524c709 into main Sep 17, 2025
29 checks passed
@JammingBen JammingBen deleted the fix/resource-item-parent-folder-line-height branch September 17, 2025 13:25
@openclouders openclouders mentioned this pull request Sep 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants