-
Notifications
You must be signed in to change notification settings - Fork 25
fix: tailwind regressions #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a92d8f to
c97ae0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Tailwind CSS regressions that were introduced in a previous update. The changes primarily address color token usage, layout styling issues, and improve visual consistency across components.
- Updated color tokens from
text-role-on-errortotext-role-errorthroughout the codebase - Fixed hover underline behavior and link styling consistency
- Improved spacing and layout in various UI components
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| UploadInfo.vue | Fixed error text color tokens |
| AccountTable.vue | Added border-t-0 class to table rows |
| ResourceTiles.vue | Adjusted checkbox padding |
| ResourceName.vue | Removed hover:underline from resource names |
| ResourceListItem.vue | Added conditional hover:underline to clickable resources |
| CreateShortcutModal.vue | Updated error color tokens and removed padding from list items |
| Projects.vue | Added width constraint to search input and updated image sizing |
| FileShares.vue | Updated spacing and added rounded corners |
| SpaceMembers.vue | Improved spacing consistency |
| InviteCollaboratorForm.vue | Cleaned up spacing and conditional rendering |
| ExpirationDatepicker.vue | Removed gap-size prop |
| ActivitiesPanel.vue | Added inline-flex class to avatars |
| DetailsPanel.vue | Improved layout for no-users state |
| layers.css | Added body overflow-hidden styling |
| Multiple design system components | Updated error color tokens from text-role-on-error to text-role-error |
| OcTag.vue | Refactored class application logic |
| OcPagination.vue | Enhanced hover states for navigation elements |
| Test snapshots | Updated to reflect styling changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c97ae0b to
34691b1
Compare
34691b1 to
74cace6
Compare
AlexAndBear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 💪
fix: tailwind regressions
See the individual commit messages for details about what has been fixed.
refs #937 (comment)