Skip to content

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 12, 2025

See the individual commit messages for details about what has been fixed.

refs #937 (comment)

@JammingBen JammingBen self-assigned this Sep 12, 2025
@JammingBen JammingBen force-pushed the fix/tailwind-regressions-2 branch from 5a92d8f to c97ae0b Compare September 12, 2025 08:31
@JammingBen JammingBen marked this pull request as ready for review September 12, 2025 09:58
Copilot AI review requested due to automatic review settings September 12, 2025 09:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Tailwind CSS regressions that were introduced in a previous update. The changes primarily address color token usage, layout styling issues, and improve visual consistency across components.

  • Updated color tokens from text-role-on-error to text-role-error throughout the codebase
  • Fixed hover underline behavior and link styling consistency
  • Improved spacing and layout in various UI components

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
UploadInfo.vue Fixed error text color tokens
AccountTable.vue Added border-t-0 class to table rows
ResourceTiles.vue Adjusted checkbox padding
ResourceName.vue Removed hover:underline from resource names
ResourceListItem.vue Added conditional hover:underline to clickable resources
CreateShortcutModal.vue Updated error color tokens and removed padding from list items
Projects.vue Added width constraint to search input and updated image sizing
FileShares.vue Updated spacing and added rounded corners
SpaceMembers.vue Improved spacing consistency
InviteCollaboratorForm.vue Cleaned up spacing and conditional rendering
ExpirationDatepicker.vue Removed gap-size prop
ActivitiesPanel.vue Added inline-flex class to avatars
DetailsPanel.vue Improved layout for no-users state
layers.css Added body overflow-hidden styling
Multiple design system components Updated error color tokens from text-role-on-error to text-role-error
OcTag.vue Refactored class application logic
OcPagination.vue Enhanced hover states for navigation elements
Test snapshots Updated to reflect styling changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the fix/tailwind-regressions-2 branch from c97ae0b to 34691b1 Compare September 12, 2025 12:36
@JammingBen JammingBen force-pushed the fix/tailwind-regressions-2 branch from 34691b1 to 74cace6 Compare September 15, 2025 09:26
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@kulmann kulmann merged commit 3999074 into main Sep 15, 2025
28 checks passed
@kulmann kulmann deleted the fix/tailwind-regressions-2 branch September 15, 2025 12:43
openclouders pushed a commit that referenced this pull request Sep 15, 2025
@openclouders openclouders mentioned this pull request Sep 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants