feat: Oc card component #1172
Merged
feat: Oc card component #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
reviewed
Sep 10, 2025
Contributor
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Besides the tiles view, the cards look good to me 👍
kulmann
force-pushed
the
oc-card-component
branch
2 times, most recently
from
18010df to
1545da8
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new OcCard component and replaces all hand-crafted usages of oc-card classes throughout the codebase to standardize card styling and improve maintainability.
Key changes include:
- New
OcCardcomponent with props for title, logo, body/header/footer classes - Updated pages to use the component instead of manual card classes
- Test updates to reflect new card structure in snapshots and selectors
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/design-system/src/components/OcCard/OcCard.vue | New OcCard component implementation with configurable props |
| packages/design-system/src/components/index.ts | Export the new OcCard component |
| packages/design-system/src/styles/layers.css | Remove old card CSS classes now handled by component |
| packages/web-runtime/src/pages/*.vue | Convert manual card markup to use OcCard component |
| packages/web-pkg/src/components/FilesList/ResourceTile.vue | Update tile card to use OcCard component |
| packages/web-app-/src/**/.vue | Convert app-specific card usage to OcCard component |
| **/*.spec.ts | Update test selectors and add OcCard stub configuration |
| **/*.snap | Update snapshots to reflect new card structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
force-pushed
the
oc-card-component
branch
3 times, most recently
from
b8e75b4 to
c640a3d
Compare
kulmann
force-pushed
the
oc-card-component
branch
3 times, most recently
from
4e3f055 to
98c24e3
Compare
kulmann
force-pushed
the
oc-card-component
branch
from
98c24e3 to
9b85eb0
Compare
openclouders
pushed a commit
that referenced
this pull request
Sep 12, 2025
* feat: add OcCard component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an
OcCardcomponent and kills and hand-crafted usages ofoc-cardoroc-login-cardclasses.Related Issue
Types of changes