fix: adjusted notification area with tailwind #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
reviewed
Sep 12, 2025
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
JammingBen
reviewed
Sep 12, 2025
Comment on lines
78
to
81
| class="markdown-container flex min-h-0 [mask-image:none]" | ||
| :class="{ | ||
| 'mask-image:linear-gradient(180deg,black,transparent)] collapsed': markdownCollapsed | ||
| }" |
Contributor
There was a problem hiding this comment.
I just saw that this removes the gradient completely, which we want to keep. The intention with the min-height was to not make it as noticeable when the description is short. But it's probably just a bad workaround. Better adjust the gradient to be less prominent in general, e.g. via mask-linear-[180deg,black,80%,transparent].
JammingBen
approved these changes
Sep 15, 2025
Contributor
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
👍 (needs a rebase though)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tailwind changes:
Related Issue: #937 (comment)
notification-Area