-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: migrate z-index to tailwind #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just a few annotations from my side. One general note: Have you tried omitting the [] in the class names? The way I read the docs, something like z-5 should work. If so, we should preferably use that.
058715a to
c5a6923
Compare
JammingBen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
refactor: migrate z-index to tailwind
Migration
z-index: xx -> z-[xx]
--oc-z-index-modal -> --z-index-modal: 9999;