fix: remove flaky resourceExists #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
force-pushed
the
flakyCheckThatFolderExist
branch
from
cb8dd32 to
b535a5f
Compare
JammingBen
approved these changes
Sep 4, 2025
Contributor
|
Code LGTM, but CI fails. Might be related? |
Contributor
Author
yeah, I adjusted failed tests for new logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests were sometimes interrupted due to flaky
resourceExists()function that used timeout-based element detection.Solution
Restructured folder creation logic - if path contains '/' then parent folders already exist, just navigate inside. No timeouts, no try-catch, simple and stable.