e2e: flaky after closing text file #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky end-to-end test by adding a page reload and wait after closing a text file. The issue occurs when the website enters an infinite loading state after creating and closing a text file in CI environments, though it doesn't reproduce locally.
- Added page reload after closing document editor
- Added explicit wait for the resource to appear after reload
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@kulmann I ran it a couple of times in CI. Everything's fine, it certainly won't get any worse if we merge it 😀 |
JammingBen
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx playwright show-trace https://s3.ci.opencloud.eu/public/web/tracing/web/15/create-and-view-resources-on-mobile-devices-alice-2025-9-2-11-16-41.zip
Sometimes the web goes into infinite loading mode after creating and closing a text file in the CI.
we have encountered this before. This does not reproduce locally. how fix in CI -> I reload page after closing file and wait for that file to appear in the list