-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: colors to tailwind #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8b89cb7 to
a6a4d9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates color and background-color styling from CSS variables to Tailwind utility classes. The migration introduces new utility classes in the design system for color roles (oc-role-{name}) and replaces legacy classes like oc-text-muted and oc-text-error with semantic role-based equivalents.
Key changes:
- Introduction of new Tailwind utility classes for color roles in the design system layer
- Migration of inline CSS color/background properties to Tailwind classes
- Replacement of legacy helper classes with semantic role-based equivalents
- Removal of redundant CSS color definitions in favor of utility classes
Reviewed Changes
Copilot reviewed 138 out of 138 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/design-system/src/styles/colors.css | New utility classes for color roles |
| packages/design-system/src/styles/layers.css | Integration of new color utilities |
| Various component and test files | Migration from CSS variables to Tailwind classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
74ebc95 to
835af1a
Compare
835af1a to
ae14b8f
Compare
refactor: colors to tailwind
Migrates
colorandbackground-colorto Tailwind.Migration
The theme color roles now exist as tailwind variables and can be used like so:
bg-role-primary,text-role-on-primary. This also supports variations, e.g.hover:text-role-on-primaryorbg-role-primary/50.Also these oc-helper classes are now redundant:
oc-text-muted>text-role-on-surface-variantoc-text-error>text-role-on-errorrefs #937