Skip to content

Conversation

@JammingBen
Copy link
Contributor

Also fixes some truncations that did not work before.

refs #937

Migration

  • oc-text-truncate > truncate
  • oc-text-nowrap > whitespace-nowrap

@JammingBen JammingBen self-assigned this Aug 20, 2025
@JammingBen JammingBen force-pushed the refactor/text-truncate-tailwind branch from c1b7765 to 33326f5 Compare August 20, 2025 08:07
@JammingBen JammingBen marked this pull request as ready for review August 20, 2025 08:36
Copilot AI review requested due to automatic review settings August 20, 2025 08:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors text truncation and word break functionality from custom CSS classes to Tailwind CSS utilities. It migrates oc-text-truncate to the standard truncate class and oc-text-nowrap to whitespace-nowrap, while also converting some custom CSS properties to Tailwind utilities for better consistency and maintainability.

Key changes include:

  • Migration of custom truncation classes to Tailwind equivalents
  • Conversion of CSS word-break and white-space properties to Tailwind utilities
  • Addition of Tailwind @layer utilities for component-specific styling
  • Removal of redundant CSS files and properties

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 6 comments.

File Description
Various snapshot files Updated test snapshots to reflect new Tailwind class names
Component Vue files Replaced oc-text-truncate with truncate and oc-text-nowrap with whitespace-nowrap
Style files Added Tailwind @layer utilities and removed redundant CSS properties
Design system components Updated core components to use Tailwind utilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the refactor/text-truncate-tailwind branch from 33326f5 to fa60ce9 Compare August 20, 2025 13:48
@JammingBen JammingBen force-pushed the refactor/text-truncate-tailwind branch from fa60ce9 to f4f7a09 Compare August 20, 2025 14:21
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-08-21 at 11 24 36

😁

@JammingBen JammingBen requested a review from kulmann August 21, 2025 09:53
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another one (icon is aligned to the left, the other views don't seem to have that though):

Screenshot 2025-08-21 at 12 17 26

@JammingBen JammingBen requested a review from kulmann August 21, 2025 10:39
@kulmann kulmann merged commit 2cb21de into main Aug 21, 2025
29 checks passed
@kulmann kulmann deleted the refactor/text-truncate-tailwind branch August 21, 2025 14:24
@openclouders openclouders mentioned this pull request Aug 21, 2025
1 task
openclouders pushed a commit that referenced this pull request Aug 21, 2025
…lwind

refactor: word breaks and truncation to tailwind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants