-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: text-align and vertical-align to tailwind #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ade11e to
978d3ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors CSS classes to migrate from custom OpenCloud utilities to standard Tailwind CSS classes for text alignment and vertical alignment. The main purpose is to consolidate styling patterns and leverage Tailwind's utility classes for better consistency and maintainability.
- Replaces custom
oc-text-*classes with Tailwindtext-*equivalents - Migrates vertical alignment from CSS properties to Tailwind
align-*classes - Updates test snapshots to reflect the new class naming
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/components/Topbar/TopBar.vue | Adds align-middle class and removes CSS vertical-align: middle |
| packages/web-runtime/src/components/Topbar/NotificationBell.vue | Replaces CSS text-align: center with text-center class |
| packages/web-runtime/src/pages/resolvePublicLink.vue | Replaces oc-text-center with text-center |
| packages/web-pkg/src/components/ViewOptions.vue | Replaces CSS vertical-align: middle with align-middle class |
| packages/web-pkg/src/components/FilesList/ResourceIcon.vue | Replaces CSS vertical-align: middle with align-middle class |
| packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue | Replaces CSS vertical-align: middle with align-middle class |
| packages/design-system/src/components/OcTableCell/OcTableCell.vue | Refactors alignment utilities to use Tailwind classes |
| packages/design-system/src/components/OcTable/OcTable.vue | Adds align-middle to table header content |
| packages/design-system/src/styles/layers.css | Updates form input alignment with Tailwind classes |
| Test snapshot files | Updates to reflect new class names in component output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
978d3ed to
8351019
Compare
kulmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💪
refactor: text-align and vertical-align to tailwind
refs #937
Migration
oc-text-center>text-centeroc-text-left>text-leftoc-text-right>text-rightThe rest had no utility classes.