Skip to content

Conversation

@JammingBen
Copy link
Contributor

refs #937

Migration

  • oc-text-center > text-center
  • oc-text-left > text-left
  • oc-text-right > text-right

The rest had no utility classes.

@JammingBen JammingBen self-assigned this Aug 19, 2025
@JammingBen JammingBen force-pushed the refactor/text-align-tailwind branch from 6ade11e to 978d3ed Compare August 19, 2025 11:48
@JammingBen JammingBen marked this pull request as ready for review August 19, 2025 11:48
Copilot AI review requested due to automatic review settings August 19, 2025 11:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors CSS classes to migrate from custom OpenCloud utilities to standard Tailwind CSS classes for text alignment and vertical alignment. The main purpose is to consolidate styling patterns and leverage Tailwind's utility classes for better consistency and maintainability.

  • Replaces custom oc-text-* classes with Tailwind text-* equivalents
  • Migrates vertical alignment from CSS properties to Tailwind align-* classes
  • Updates test snapshots to reflect the new class naming

Reviewed Changes

Copilot reviewed 89 out of 89 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/web-runtime/src/components/Topbar/TopBar.vue Adds align-middle class and removes CSS vertical-align: middle
packages/web-runtime/src/components/Topbar/NotificationBell.vue Replaces CSS text-align: center with text-center class
packages/web-runtime/src/pages/resolvePublicLink.vue Replaces oc-text-center with text-center
packages/web-pkg/src/components/ViewOptions.vue Replaces CSS vertical-align: middle with align-middle class
packages/web-pkg/src/components/FilesList/ResourceIcon.vue Replaces CSS vertical-align: middle with align-middle class
packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue Replaces CSS vertical-align: middle with align-middle class
packages/design-system/src/components/OcTableCell/OcTableCell.vue Refactors alignment utilities to use Tailwind classes
packages/design-system/src/components/OcTable/OcTable.vue Adds align-middle to table header content
packages/design-system/src/styles/layers.css Updates form input alignment with Tailwind classes
Test snapshot files Updates to reflect new class names in component output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JammingBen JammingBen force-pushed the refactor/text-align-tailwind branch from 978d3ed to 8351019 Compare August 20, 2025 13:28
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

@JammingBen JammingBen merged commit 0a2c337 into main Aug 20, 2025
29 checks passed
@JammingBen JammingBen deleted the refactor/text-align-tailwind branch August 20, 2025 14:18
openclouders pushed a commit that referenced this pull request Aug 20, 2025
refactor: text-align and vertical-align to tailwind
@openclouders openclouders mentioned this pull request Aug 20, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants