refactor: migrate font-size and line-height to tailwind #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
refactor/font-size-tailwind
branch
from
bce1636 to
a397236
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates font-size and line-height styles from custom SCSS classes to Tailwind CSS utilities across the entire codebase. The migration replaces custom oc-text-* size classes with standardized Tailwind equivalents and removes related unused SCSS code.
- Replaces custom font-size classes (
oc-text-xsmall,oc-text-small, etc.) with Tailwind text utilities (text-xs,text-sm, etc.) - Updates line-height implementations to use Tailwind's
leading-*classes where needed - Removes obsolete SCSS font-size and line-height definitions from the design system
Reviewed Changes
Copilot reviewed 100 out of 100 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/tests/unit/components/Topbar/snapshots/UserMenu.spec.ts.snap | Updates test snapshots to reflect new Tailwind classes |
| packages/web-runtime/src/pages/ | Migrates error message font sizes in public/private link resolvers and 404 pages |
| packages/web-runtime/src/components/ | Updates component templates with new Tailwind text size classes |
| packages/web-pkg/tests/unit/components/ | Updates test snapshots for components using new text sizing |
| packages/web-pkg/src/components/ | Migrates component templates to use Tailwind text utilities |
| packages/web-app-files/src/components/ | Updates file management components with new text sizing |
| packages/web-app-admin-settings/src/components/ | Migrates admin interface components to Tailwind text classes |
| packages/design-system/src/ | Removes obsolete SCSS font-size definitions and adds Tailwind layer configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kulmann
approved these changes
Aug 20, 2025
Contributor
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Looks good to me (literally). 💪
openclouders
pushed a commit
that referenced
this pull request
Aug 20, 2025
refactor: migrate font-size and line-height to tailwind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes some unused classes in the scss files.
Migration
oc-text-xsmall>text-xsoc-text-small>text-smoc-text-medium>text-baseoc-text-large>text-lgoc-text-xlarge>text-xlThe
line-heightgets determined by the giventext-class. However, it can also be adjusted separately via theleading-classes.refs #937